Skip to content

avoid deprecated std::iterator #7468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

avoid deprecated std::iterator #7468

wants to merge 1 commit into from

Conversation

kroening
Copy link
Member

@kroening kroening commented Jan 9, 2023 •
edited
Loading

C++17 deprecates std::iterator. The recommended alternative is to use an iterator_category member.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@kroening
avoid deprecated std::iterator
a79af35 
C++17 deprecates std::iterator.  The recommended alternative is to use an
iterator_category member.
@tautschnig
Copy link
Collaborator

I'm certainly in favour of removing any use of deprecated functions. But:

  1. Builds are failing with the current set of proposed changes.
  2. Is that code that's using std::iterator actually being used? Should we consider removing it?

@tautschnig tautschnig assigned kroening and unassigned tautschnig Jan 9, 2023
@thomasspriggs
Copy link
Contributor

@kroening Is this something you are actively working on, or would you be happy for someone else to take on the work of removing our usage of the deprecated std::iterator?

@kroening
Copy link
Member Author

@kroening Is this something you are actively working on, or would you be happy for someone else to take on the work of removing our usage of the deprecated std::iterator?

I'd be happy to see someone else take it!

@thomasspriggs thomasspriggs mentioned this pull request Nov 28, 2023
Merged
7 tasks
@thomasspriggs
Copy link
Contributor

There is an updated version of this (which passes CI) here - #8088

@thomasspriggs
Copy link
Contributor

The changes from this PR have now been completed in this merged PR instead - #8088

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tautschnig tautschnig Awaiting requested review from tautschnig tautschnig will be requested when the pull request is marked ready for review tautschnig is a code owner

@peterschrammel peterschrammel Awaiting requested review from peterschrammel peterschrammel will be requested when the pull request is marked ready for review peterschrammel is a code owner

Assignees

@kroening kroening

Labels
cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kroening @tautschnig @thomasspriggs